[FFmpeg-devel] [RFC][PATCH 2/4] build: Report yasm assembler like e.g. compiler is

[Michael Niedermayer]

On Sun, Jan 22, 2012 at 07:44:43PM +0100, Alexander Strasser wrote:
> Hi,
> 
> Michael Niedermayer wrote:
> > On Mon, Jan 16, 2012 at 12:48:30AM +0100, Alexander Strasser wrote:
> > > 
> > > Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> > > ---
> > >  configure |    5 ++++-
> > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/configure b/configure
> > > index f0d4400..474d684 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -3382,7 +3382,10 @@ fi
> > >  echo "big-endian                ${bigendian-no}"
> > >  echo "runtime cpu detection     ${runtime_cpudetect-no}"
> > >  if enabled x86; then
> > > -    echo "${yasmexe}                      ${yasm-no}"
> > > +    yasm_res=$yasmexe
> > > +    disabled yasm && yasm_res=no
> > > +
> > > +    echo "yasm                      ${yasm_res}"
> > 
> > i think this would print
> > 
> > yasm                    nasm
> > 
> > when nasm is used and this looks a bit odd
> 
>   Yes it would. But I don't think it is too odd at all. We also don't
> have any "#if HAVE_NASM" in the source code so, that could be argued to
> look equally odd. And isn't it what we are doing? Using nasm to assemble
> the source files that were written for yasm (IIRC yasm was initially
> based on nasm and most of (all?) our code should be compatible)?
> 
>   Printing always the same "key" on the right seems like the right thing
> to do (to me at least). Also I would dislike having full path printed
> at the lefthand of the summary which would look odd to me.
> 
>   I have no strong preference though.

we could list them as
Intel syntax assembler      yasm
AT&T syntax assembler       as

or
yasm/nasm assembler         yasm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120122/7f33fddf/attachment.asc>