[FFmpeg-devel] [RFC][PATCH 2/4] build: Report yasm assembler like e.g. compiler is
Alexander Strasser
eclipse7 at gmx.net
Mon Jan 23 21:52:15 CET 2012
Hi,
Michael Niedermayer wrote:
> On Sun, Jan 22, 2012 at 07:44:43PM +0100, Alexander Strasser wrote:
> > Michael Niedermayer wrote:
[...]
> > > i think this would print
> > >
> > > yasm nasm
> > >
> > > when nasm is used and this looks a bit odd
> >
> > Yes it would. But I don't think it is too odd at all. We also don't
> > have any "#if HAVE_NASM" in the source code so, that could be argued to
> > look equally odd. And isn't it what we are doing? Using nasm to assemble
> > the source files that were written for yasm (IIRC yasm was initially
> > based on nasm and most of (all?) our code should be compatible)?
> >
> > Printing always the same "key" on the right seems like the right thing
> > to do (to me at least). Also I would dislike having full path printed
> > at the lefthand of the summary which would look odd to me.
> >
> > I have no strong preference though.
>
> we could list them as
> Intel syntax assembler yasm
LGTM
Maybe "yasm-compatible assembler" would do too while being
a bit more precise and in agreement with the help description
of the --yasmexe option.
> AT&T syntax assembler as
I am not sure we should print this at all, as to my knowledge
we have only inline assembly in AT&T syntax and therefore this
would probably always print the same as "C compiler".
> or
> yasm/nasm assembler yasm
This looks a bit too much and if there would be another compatible
assembler (yayasm ;)) we would need to add it there too.
Does anyone else have any preferences?
Alexander
More information about the ffmpeg-devel
mailing list