[FFmpeg-devel] [PATCH 1/4] concatdec: add support for specifying inpoint of files

[Marton Balint]

On Mon, 6 Jul 2015, Nicolas George wrote:

> L'octidi 18 messidor, an CCXXIII, Marton Balint a écrit :
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  doc/demuxers.texi       | 17 +++++++++++++++++
>>  libavformat/concatdec.c | 48 +++++++++++++++++++++++++++++++++++-------------
>>  2 files changed, 52 insertions(+), 13 deletions(-)
>
> I like the feature, but I find the name of the directive, "in", too generic.
> Maybe "seek" is the best choice?

I chose the "in" and "out" keywords because for intra frame (and exactly 
interleaved) content (where packet based cutting actually works without 
additional magic) it matches the semantics of inpoint and outpoint in an 
EDL list.

I can change it if you still prefer seek.

>
> Also, the timestamp computation code is starting to be a bit complex. Maybe
> now is a good time to move file_start_time to the per-file structure. But I
> will not consider this blocking.

Are you referring to file_start_time or file_inpoint?

Regards,
Marton