[FFmpeg-devel] [PATCH 1/4] concatdec: add support for specifying inpoint of files

Nicolas George george at nsup.org
Wed Jul 8 12:48:06 CEST 2015

L'octidi 18 messidor, an CCXXIII, Marton Balint a écrit :
> I chose the "in" and "out" keywords because for intra frame (and exactly
> interleaved) content (where packet based cutting actually works without
> additional magic) it matches the semantics of inpoint and outpoint in an EDL
> list.
> I can change it if you still prefer seek.

I suppose "inpoint" and "outpoint" in full could satisfy us both, could it
not? If the documentations contains the words "seek" and "skip", it should
be enough that all users should be able to find it.

> Are you referring to file_start_time or file_inpoint?

I was referring to file_start_time: currently, it is recomputed for each
packet, but that is fine since the computation is very simple. Your patch
makes it a bit more complex, it becomes useful to share it. You did some of
it in get_cur_file_inpoint(), but I suspect it could be even simpler. In
particular, a single field in the structure would make it easier to see that
it is constant.

But as I said, I do not object the patch just because of that.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150708/ef4d27a4/attachment.sig>

More information about the ffmpeg-devel mailing list