[FFmpeg-devel] [PATCH] configure: Add user options to enable gcrypt/gmp for rtmp(t)e support.

Matt Oliver protogonoi at gmail.com
Sat Nov 21 16:28:14 CET 2015

Adding rtmp(t)e support when not using openssl or librtmp uses either gmp
or gcrypt to implement the required Diffie-Hellmann code. Since this code
can be compiled using either gmp or gcrypt a command line option to
enable/disable either of those libs needs to be provided.

Currently configure seems to enable both gmp and gcrypt if gnutls is
enabled (line 5476) with no user visible option to disable this behavior
(or atleast to select which of the external libs should be used). Currently
if both dependencies are available then both will be automatically linked
despite only 1 being used and this behavior doesnt appear to be visible to
the user. It also appears to be just plain wrong as gmp is used by default
over gcrypt despite gmp being LGPL v3 (gcrypt and gnutls are v2.1) and it
is not checking if version 3 is enabled. So currently a v3 lib is being
stealth linked without version3 being enabled or any user input/output.
This is also currently only done when using gnutls for other rtmp
operations which means that when not using gnutls (i.e. the recently added
schannels) there is no user visible way to enable the rtmp(t)e support.

This patch fixes the above by making both gmp/gcrypt an user visible option
and removing the code that automatically enables their usage only when
using gnutls.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure-Add-user-options-to-enable-gcrypt-gmp-for-.patch
Type: application/octet-stream
Size: 3268 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151122/b63c5627/attachment.obj>

More information about the ffmpeg-devel mailing list