[FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

Tomas Härdin git at haerdin.se
Mon Dec 26 12:32:48 EET 2022


lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer:
> 
>          index_table->nb_ptses += s->index_duration;
> +        // If index_duration is substantially larger than
> nb_index_entries then this algorithm which
> +        // allocates index_duration elements is a bad idea. All
> files i tried have it equal
> +        if (s->index_duration > 10LL * s->nb_index_entries)
> +            return AVERROR_PATCHWELCOME;

I was going to say this can overflow but the 10LL ensures it can't. So
looks OK.

/Tomas



More information about the ffmpeg-devel mailing list