[FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

Michael Niedermayer michael at niedermayer.cc
Mon Dec 26 23:54:12 EET 2022


On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote:
> lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer:
> > 
> >          index_table->nb_ptses += s->index_duration;
> > +        // If index_duration is substantially larger than
> > nb_index_entries then this algorithm which
> > +        // allocates index_duration elements is a bad idea. All
> > files i tried have it equal
> > +        if (s->index_duration > 10LL * s->nb_index_entries)
> > +            return AVERROR_PATCHWELCOME;
> 
> I was going to say this can overflow but the 10LL ensures it can't. So
> looks OK.

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221226/f6f5b689/attachment.sig>


More information about the ffmpeg-devel mailing list