[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: Recognize and Ignore MXF fill boxes

Tomas Härdin git at haerdin.se
Fri Sep 13 14:59:52 EEST 2024


fre 2024-09-13 klockan 08:23 +0000 skrev Nicolas Gaullier:
> 
> - why not using a simple "if" on the av_log rather than inserting a
> new block of code ?

That's way ugly

RE: performance, we might want to move to a hash table based approach
so we don't scan the entire table every time. The approach in this
patch would be detrimental to such a change (it's an extra if that's
always evaluated), hence why I prefer a table based approach. I'll post
an alternative patch in a bit

Also I just noticed the "Dark key" nag only get printed with -loglevel
verbose. Hence why it's gone unnoticed

/Tomas


More information about the ffmpeg-devel mailing list