[FFmpeg-trac] #10142(avfilter:open): scdet filter not logging some frames score

[FFmpeg]

#10142: scdet filter not logging some frames score
----------------------------------+------------------------------------
             Reporter:  colemarc  |                    Owner:  (none)
                 Type:  defect    |                   Status:  open
             Priority:  minor     |                Component:  avfilter
              Version:  5.1.2     |               Resolution:
             Keywords:  scdet     |               Blocked By:
             Blocking:            |  Reproduced by developer:  0
Analyzed by developer:  0         |
----------------------------------+------------------------------------
Comment (by colemarc):

 Replying to [comment:4 Elon Musk]:
 > This have been fixed in master version.
 >
 > Could you confirm?

 I can confirm that my particular issue is fixed, but I believe that commit
 07485a697552641609df73fd411de1ea964f1ef2 introduced a discrepancy, because
 now the filter logs when score is '''greater than or equal''' to threshold
 (see line 166), but (if sc_pass==1) it forwards the frame only if the
 score is '''strictly greater''' than threshold (see line 173).
 This behaviour is probably unexpected since it does not conform to
 documentation.

 I suggest correcting line 173 as well.

 https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/07485a697552641609df73fd411de1ea964f1ef2:/libavfilter/vf_scdet.c#l166
 https://ffmpeg.org/ffmpeg-filters.html#scdet-1
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/10142#comment:5>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker