[FFmpeg-devel] [PATCH] Move the video size and rate abbreviations system from libavformat to libavcodec

Michael Niedermayer michaelni
Tue Jun 12 09:53:48 CEST 2007


Hi

On Tue, Jun 12, 2007 at 09:35:58AM +0200, Benoit Fouet wrote:
> Michael Niedermayer wrote:
> > Hi
> >
> > On Mon, Jun 11, 2007 at 02:35:47PM +0200, Stefano Sabatini wrote:
> >   
> >> On date Monday 2007-06-11 14:11:36 +0200, Benoit Fouet encoded:
> >>     
> >>> Hi,
> >>>
> >>> Stefano Sabatini wrote:
> >>>       
> >>>> Index: libavformat/utils.c
> >>>> ===================================================================
> >>>> --- libavformat/utils.c	(revision 9235)
> >>>> +++ libavformat/utils.c	(working copy)
> >>>> -int parse_frame_rate(int *frame_rate, int *frame_rate_base, const char *arg)
> >>>> +int parse_frame_rate(int *frame_rate_num, int *frame_rate_den, const char *arg)
> >>>>   
> >>>>         
> >>> why do you rename those parameters ?
> >>>       
> >> First solution:
> >> int parse_frame_rate(int *frame_rate, int *frame_rate_base, const char *arg)
> >> {
> >>     AVRational frame_rate_q;
> >>     int ret = av_parse_video_frame_rate(&frame_rate_q, arg);
> >>     *frame_rate= frame_rate_q.num;
> >>     *frame_rate_base= frame_rate_q.den;
> >>     return ret;
> >> }
> >>
> >> Second one:
> >> int parse_frame_rate(int *frame_rate_num, int *frame_rate_den, const char *arg)
> >> {
> >>     AVRational frame_rate;
> >>     int ret = av_parse_video_frame_rate(&frame_rate, arg);
> >>     *frame_rate_num= frame_rate.num;
> >>     *frame_rate_den= frame_rate.den;
> >>     return ret;
> >> }
> >>
> >> The second one looks better to me, but that doesn't really matter, and
> >> yep, it's a cosmetic change, it seems I can't resist without making them ;-),
> >> so please choose which you prefer (first one attached).
> >>     
> >
> > i think iam fine with the patch
> >
> >   
> 
> which one ? :)

i think there is just one attached
either way i have no strong preferance for one of the above 2 ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070612/eb6cb8a9/attachment.pgp>



More information about the ffmpeg-devel mailing list