[FFmpeg-devel] [PATCH] Re: new command-line option for ffplay

Vladimir Pantelic pan
Fri Jun 25 07:59:09 CEST 2010

Alexei Svitkine wrote:

> Hmm, I would have thought the refactoring would be welcome - since it
> makes the code cleaner (the current input loop code is too giant of a
> function, imho). Seems the current policy would lead towards bad code
> lingering, since there will be less incentive to clean up code if it
> has to be done separately.

 > For instance, I don't really care so much about this specific code
> being cleaner - but I thought I'd do a favor to fix it up while I'm
> here. Clearly this is not welcome (in the way I did it), so I'd
> probably settle for just the simple patch that keeps the function huge
> as it is now, and not bother with the cleanup patch after.

send both, cleanup and functional changes, as separate patches.

More information about the ffmpeg-devel mailing list