[FFmpeg-devel] [PATCH 1/2] lavf: try reading id3v1 header for all formats

Michael Niedermayer michaelni
Tue Nov 30 00:14:46 CET 2010

On Mon, Nov 29, 2010 at 11:51:18PM +0100, Michael Karcher wrote:
> Am Montag, den 29.11.2010, 19:43 +0100 schrieb Reimar D?ffinger:
> > On Mon, Nov 29, 2010 at 09:41:51AM +0100, Anton Khirnov wrote:
> > > similarly to id3v2 case, id3v1 headers can be found on anything, so it
> > > makes sense to check for their presence if the file is seekable and no
> > > other metadata was found.
> [...]
> > Michael's suggestion was to keep the code-deduplication with introducing
> > potentially extra issues by having a flag in the demuxer description
> > that says whether we should look for id3v1.
> The orginal claim was that id3v1 is attached to any format you can think
> of, so annotating the format doesn't seem to make sense to me under
> these circumstances. What would make sense to me would be introducing a
> "seek is cheap" flag for easily seekable sources (like file://, unlike
> http://).

some formats will not even demux if you attach id3 not to mention id3 is for
audio and until i see avi, mpg anfd mov with id3 tags i assume these are
uncommon enough to not matter.

Also the question about seeking being cheap is something that we cannot awnser
any file can be a remotely mounted thingy and this can be slow or fast depending
on network latency ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101130/7a4cc2b9/attachment.pgp>

More information about the ffmpeg-devel mailing list